Skip to content

Update webauthn to v2 #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

Update webauthn to v2 #5458

merged 2 commits into from
Nov 19, 2024

Conversation

@WyattMufson
Copy link
Contributor

@WyattMufson WyattMufson commented Nov 19, 2024 •
edited by pr-codex bot
Loading

Problem solved

Updates to the latest version of @passwordless-id/webauthn which fixes issues with applications using thirdweb built with commonjs

PR-Codex overview

This PR updates the @passwordless-id/webauthn package from version 1.6.1 to 2.1.2, resulting in changes to the implementation of the PasskeyWebClient class in the passkeys.ts file, enhancing the registration and authentication processes.

Detailed summary

  • Updated @passwordless-id/webauthn dependency in package.json and pnpm-lock.yaml.
  • Modified the register method in PasskeyWebClient:
    • Changed parameters to use user instead of name.
    • Accessed clientData and other properties from registration.response.
  • Updated the authenticate method in PasskeyWebClient:
    • Changed parameters to use allowCredentials instead of credentialId.
    • Accessed clientData and other properties from result.response.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9822a21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 19, 2024

@WyattMufson is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 19, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@socket-security
Copy link

socket-security bot commented Nov 19, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@passwordless-id/[email protected] None 0 162 kB dagnelies

🚮 Removed packages: npm/@passwordless-id/[email protected]

View full report↗︎

@gregfromstl
Copy link
Contributor

gregfromstl commented Nov 19, 2024

Hey @WyattMufson, thanks for opening this! We're actually going to be replacing this library with Ox today which should fix this issue.

@gregfromstl gregfromstl reopened this Nov 19, 2024
@gregfromstl
Copy link
Contributor

gregfromstl commented Nov 19, 2024

Change of plans, going to get this merged and migrate to Ox another time

@jnsdls
Copy link
Member

jnsdls commented Nov 19, 2024

image

@codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 31.35%. Comparing base (2591c75) to head (9822a21).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/src/wallets/in-app/web/lib/auth/passkeys.ts 4.16% 23 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5458       +/-   ##
===========================================
- Coverage   45.50%   31.35%   -14.16%     
===========================================
  Files        1071     1067        -4     
  Lines       55743    55504      -239     
  Branches     4031     2923     -1108     
===========================================
- Hits        25367    17401     -7966     
- Misses      29689    37438     +7749     
+ Partials      687      665       -22
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2591c75
packages 22.98% <4.16%> (-17.64%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...irdweb/src/wallets/in-app/web/lib/auth/passkeys.ts 9.37% <4.16%> (-0.15%) ⬇️

... and 238 files with indirect coverage changes

---- 🚨 Try these New Features:

@vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ❌ Failed (Inspect) Nov 19, 2024 10:04pm

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 19, 2024
@gregfromstl Graphite App
Copy link
Contributor

gregfromstl commented Nov 19, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 19, 5:03 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 19, 5:24 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 19, 5:25 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Nov 19, 2024
@joaquim-verges joaquim-verges merged commit 3df0541 into thirdweb-dev:main Nov 19, 2024
26 of 31 checks passed
@WyattMufson WyattMufson deleted the update-webauthn-v2 branch November 20, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

+1 more reviewer

@gregfromstl gregfromstl gregfromstl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WyattMufson @gregfromstl @jnsdls @joaquim-verges